Repository navigation
Conversation
Signed-off-by: Kevin Wang <wy721@qq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the guest side of #1577 to 0.5.x, so a 0.5.x guest can boot an app whose contract requires a launch ticket. Without it, the guest never sends the ticket a 0.6.4 VMM writes to its sys-config, and a 0.6.4 KMS refuses it as
Invalid launch ticket.SysConfiggainslaunch_ticket. It is never put invm_config, which attestations embed.GetAppKeyRequestandSignCertRequestgainlaunch_ticket = 5, matching feat: KMS-enforced launch tickets #1577. dstack-util sends it inGetAppKey, andCertRequestClientinSignCert, for both dstack-util and the guest agent.Not included: the KMS, contract, auth backend and VMM parts, and KMS onboarding, which stay on 0.6.4. A 0.5.x KMS ignores the new fields.
Tests:
cargo testfor dstack-types, cert-client, dstack-util and dstack-guest-agent;cargo check --testsfor dstack-kms and dstack-gateway.